Use characters supported everywhere #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These characters are supported by the Consolas font, which is the default font use by the Windows console prompts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposed changes here use characters are supported by the default Windows fonts ( Consolas, Courier New, etc.) used by the Windows console prompts & Powershell.
Currently the default characters used here are unfortunately not supported by the Consolas and they just render as squares
Before
Courier New
I am able to change the font preference to something with support (Source Code Pro), but many users will likely not know how/why to do this and it really should "just work" with the defaults out of the box.
After
Courier New
Consolas
