Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support type and call hierarchy #74

Merged
merged 7 commits into from Apr 22, 2023

Conversation

tcx4c70
Copy link
Contributor

@tcx4c70 tcx4c70 commented Mar 7, 2023

This PR is trying to implement type and call hierarchy.

Implemented RPC:

  • textDocument/prepareTypeHierarchy
  • typeHierarchy/supertypes
  • typeHierarchy/subtypes
  • textDocument/prepareCallHierarchy
  • callHierarchy/incomingCalls
  • callHierarchy/outgoingCalls

Signed-off-by: Adam Tao <tcx4c70@gmail.com>
Signed-off-by: Adam Tao <tcx4c70@gmail.com>
Signed-off-by: Adam Tao <tcx4c70@gmail.com>
@tcx4c70 tcx4c70 force-pushed the feat/call-and-type-hierarchy branch from 705ffde to 7054bbe Compare April 17, 2023 00:23
Don't show some special base type, e.g., Object, ValueType.

Signed-off-by: Adam Tao <tcx4c70@gmail.com>
Signed-off-by: Adam Tao <tcx4c70@gmail.com>
Update the content of Name & Detail of HierarchyItem:
1. Name: only contains type name or method name
2. Detail: contains full namespace name (for type) or full type name
   (for method)

Signed-off-by: Adam Tao <tcx4c70@gmail.com>
@tcx4c70
Copy link
Contributor Author

tcx4c70 commented Apr 20, 2023

Hi @razzmatazz . For TODO "Implement callHierarchy/outgoingCalls", I'm not going to implement it now since I doesn't find any related method from roslyn project and Visual Studio & C# plugin in Visual Studio Code doesn't support it now (correct me if I'm wrong). What's your opinion?

If you agree with it, I'll remove WIP and publish the PR.

@razzmatazz
Copy link
Owner

Hi @razzmatazz . For TODO "Implement callHierarchy/outgoingCalls", I'm not going to implement it now since I doesn't find any related method from roslyn project and Visual Studio & C# plugin in Visual Studio Code doesn't support it now (correct me if I'm wrong). What's your opinion?

If you agree with it, I'll remove WIP and publish the PR.

Feel free to let this go. Lets release early and fix things along the go.

@tcx4c70 tcx4c70 changed the title [WIP] Support type and call hierarchy Support type and call hierarchy Apr 22, 2023
@razzmatazz razzmatazz merged commit d3528d4 into razzmatazz:master Apr 22, 2023
2 checks passed
@razzmatazz
Copy link
Owner

Bildschirmfoto 2023-04-22 um 12 32 24

beautiful!

@tcx4c70 tcx4c70 deleted the feat/call-and-type-hierarchy branch April 22, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants