This repository has been archived by the owner on Feb 6, 2024. It is now read-only.
Remove acronym inflector for CAS #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In that scenario, simply including the CASino Engine into that application will cause the entire app to "blow up". In accordance with the "Principle of least astonishment", CASino should not mandate how certain words are inflected unless they are entirely unique to CASino. * Removes the inflection rule for the CAS acronym * There was no need to edit any code, CAS is not used in the CASino code base by itself
|
This looks good to me. @pencil, what do you think? |
pencil
added a commit
that referenced
this pull request
Aug 20, 2015
…flection Remove acronym inflector for CAS
|
Thanks 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Host applications might be using "Cas" as a constant and not using "CAS"
This references issue 101
In that scenario, simply including the CASino Engine into that application will cause the entire app to "blow up".
In accordance with the "Principle of least astonishment", CASino should not mandate how certain words are inflected unless they are entirely unique to CASino.