This repository has been archived by the owner on Feb 6, 2024. It is now read-only.
Cherry pick fixes for #51 and #58 (closes #64) #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
|
@pencil What do you think? Should I look into backporting other bugfixes or is it enough for a 2.0.7 release? :) |
|
Thank you! Think it should be enough for a bugfix release. Did you test it though? |
|
Yes, these two commits solved my issues and the generic functionality still works. I haven't done full manual testing though. Later tonight I'll test it with root mount point as well and get back to you. You can hold the merge until then. |
|
@pencil I tested it with root mount point, it seems OK to me. |
|
Thanks. Just released |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport fixes for login issues caused by custom route mount point.