Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

two "make test" issues #25

Merged
merged 2 commits into from
Nov 7, 2016
Merged

two "make test" issues #25

merged 2 commits into from
Nov 7, 2016

Conversation

kilobyte
Copy link
Contributor

There are two problems with "make test":

  • because of a pointless dependency on "all", it requires a bunch of python-pil stuff. That'd require everyone who wants to build your font from source to install PIL. It's not that fat a dependency, but since there's no gain from it unless one wants the sample image, it's better to not require it. I've also added a "make fonts" target that generates just the font files but not the sample image.
  • with non-ancient fontforge versions that @copyninja plans to upload to Debian unstable in the next few days, the validation fails with:
Attempt to unget two characters
CHECKING     3270Medium.otf
The glyph named Omega is mapped to U+03A9.
  But its name indicates it should be mapped to U+2126.
PASS         3270Medium.otf

Copyright (c) 2000-2014 by George Williams. See AUTHORS for Contributors.
 License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
 with many parts BSD <http://fontforge.org/license.html>. Please read LICENSE.
 Based on sources from 20161015-ML-D.
 Based on source from git with hash: 
Attempt to unget two characters
CHECKING     3270Medium.pfm
ERROR     22 Two glyphs have the same Unicode code point
FAIL         3270Medium.pfm

This looks like a bug in Fontforge to me, as you request "Omega" (ie U+03A9 GREEK CAPITAL LETTER OMEGA) rather than U+2126 OHM SIGN, but since the workaround is so simple (s/Omega/Omega.greek/), it's easier to just do so.

@kilobyte
Copy link
Contributor Author

kilobyte commented Nov 5, 2016

Refreshed the patches.

Your addition of "make derived" allows one to build the fonts without needing the toolchain for the sample image, but "make test" still depends on "all".

As for "Omega" vs "Omega.greek", fontforge guys recommend using full names even if/when the encoding regression is fixed on their side.

@rbanffy
Copy link
Owner

rbanffy commented Nov 5, 2016

Wow! Thanks. Since I am a heavy Python user, I didn't think twice about having PIL (Pillow, actually) installed. I'll make sure the patch merges cleanly with the develop branch (I think it does, sorry about making you refresh the patches) and move ahead.

Thank you for the help!

@rbanffy rbanffy changed the base branch from master to develop November 7, 2016 13:02
@rbanffy rbanffy merged commit dcaa7d3 into rbanffy:develop Nov 7, 2016
@kilobyte kilobyte deleted the testfix branch November 12, 2016 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants