Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major APL set fixes, combining chars, build process fixes, fix derived font names #84

Merged
merged 43 commits into from
Jan 16, 2021

Conversation

rbanffy
Copy link
Owner

@rbanffy rbanffy commented Jan 16, 2021

  • Add a hooks folder with a suggested pre-commit hook
  • Add APL and BQN glyphs ⊂, ⊃, ⊆, ⊇, ⊏, ⊐, ⊑, ⊒, ⊔, ⊓, ⊕, ⊖, ⊗, ⊘, ⊙, ⌾,
    ⊝, ⋆, ⌈, ⌉, ⌊, ⌋, ⁼, ⇐, ⇒, ⊸, ⟜, ⟨, ⟩, ⋄, ∧, ∨, ⊢, ⊣, ⊤, ⊥, ≢, ⚇, ⎉,
    ⎊, ◴, ◵, ◶, ◷, ⥊, ⥋, ∾, ‿, ↩, ↪, ≍, 𝕩, 𝕨, 𝕤, 𝕣, 𝕘, 𝕗, 𝕏, 𝕎, 𝕊, 𝔾, 𝔽
  • Modify some glyphs to improve consistency in APL and BQN code: ¬, ⌙,
    ⌜, ⌝, ⌞, ⌟, •, ∩, ⌐, ○, ∪, ∘, ⍷
  • Fix ●
  • Add combining glyphs ̉, ̍, ̎, ̏, ̐, ̑, ̒ , ̓ , ̔ , ̕ , ̖ , ̗ , ̜ , ̘ , ̙ , ̚ , ̛ , ̜ ,ㄍ,
    ̞ , ̟ , ̠ , ̡ , ̢ , ̣ , ̤ , ̥ , ̦ , ̧ , ̨ , ̩ , ̪ , ̫ , ̬ , ̭ , ̮ , ̯ , ̰ , ̱ , ̲ , ̳ , ̴ ,
    ̵ , ̶ , ̷ , ̸ , ̹ , ̺ , ̻ , ̼ , ̽ , ̾ , ̿, ̀ , ́ , ͂ , ̓ , ̈́ , ͅ , ͆ , ͇ , ͈ , ͉ , ͊ , ͋ , ͌ ,
    ͎ , ͍ , ͐ , ͑ , ͒ , ͓ , ͔ , ͕ , ͖ , ͗ , ͘ , ͙ , ͚ , ͛ , ͜ , ͝ , ͞ , ͟ , ͠ , ͡ , ͢ , ͣ , ͤ ,
    ͥ , ͦ , ͧ , ͨ , ͩ , ͪ , ͫ , ͬ , ͭ , ͮ , ͯ .
  • Add ँ, ʻ, ꭪, ꭫
  • Add composing glyphs to rendering test
  • Adjust derived font names
  • Simplify cedilla, fix overlap in ç and Ç

rbanffy and others added 30 commits September 17, 2020 11:34
Because each Select unselects the previous one.
Sourcery refactored develop branch
@sourcery-ai
Copy link

sourcery-ai bot commented Jan 16, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.43%.

Quality metrics Before After Change
Complexity 1.02 ⭐ 1.02 ⭐ 0.00
Method Length 79.20 🙂 79.20 🙂 0.00
Working memory 14.02 😞 14.46 😞 0.44 👎
Quality 61.50% 🙂 61.07% 🙂 -0.43% 👎
Other metrics Before After Change
Lines 126 125 -1
Changed files Quality Before Quality After Quality Change
generate_sample_image.py 65.94% 🙂 66.48% 🙂 0.54% 👍
test_font_rendering.py 54.54% 🙂 53.19% 🙂 -1.35% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
generate_sample_image.py draw_sample 1 ⭐ 150 😞 15 😞 54.05% 🙂 Try splitting into smaller methods. Extract out complex expressions
generate_sample_image.py draw_readability_test 0 ⭐ 53 ⭐ 11 😞 74.11% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@rbanffy rbanffy merged commit 22d8ab2 into master Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants