Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to incorporate into Lavender theme #11

Open
GitPuffy opened this issue Apr 27, 2016 · 7 comments
Open

How to incorporate into Lavender theme #11

GitPuffy opened this issue Apr 27, 2016 · 7 comments

Comments

@GitPuffy
Copy link

I use the Lavender theme and I am able to get the smoothshort link when I copy the topic directly from within the category that it resides. What do I need to add in the Lavender theme to add your link copy ability to other parts of the theme?

Thank you. #

@rbeer
Copy link
Owner

rbeer commented Apr 28, 2016

@GitPuffy
Bug with missing hashed links on the home page is fixed.

In general:
It pretty much doesn't matter where you put the link. The plugin looks for or Elements. Where aPostUrl is taken from every entry in ajaxify.data.posts and aTopicUrl from entries in ajaxify.data.topics or ajaxify.data.categories[*].posts[0].topic.

@rbeer rbeer closed this as completed Apr 28, 2016
@GitPuffy
Copy link
Author

GitPuffy commented Apr 28, 2016

You are so close on this! I have tested your updates to master and found another issue with Lavender.

  • I get shortlinks from the home (categories route) page
  • I get shortlinks from the recent, popular, etc., routes
  • I do not get a shortlink from within a nested category (but do get a shortlink if I go all of the way into the actual category).

I have categories such as:

  • Category TopA
    • Category NestedUnderA_1
    • Categroy NestedUnderA_2
  • Category TopB
    • Category NestedUnderB_1
    • Category NestedUnderB_2

When I am actually in the category TopA and see the teasers for the most recent posts for NestedUnderA_1 and NestedUnderA_2 if I right-click/copy link from there I do not get a smoothshort link for the post.

I don't know if this is workable by your software but passing along the anomaly.

Thank you.

@rbeer rbeer reopened this Apr 28, 2016
@rbeer
Copy link
Owner

rbeer commented Apr 28, 2016

Ouch! I actually never tested nested categories. Thanks! 👍

Of course it's possible! Everything is possible in programming - only matter is time. ;D
I have yet to get the forum itself to show me multiple sub categories, though. :/

Will go over it, tomorrow. :)

@GitPuffy
Copy link
Author

If you want to see my production and test sites I will share the urls with you.

@rbeer
Copy link
Owner

rbeer commented May 2, 2016

@GitPuffy

Sure, seeing how the code behaves in another setup always helps. 👍

0.3.2 should fix the teasers everywhere.

P.S. Did you get my email; around friday?

@GitPuffy
Copy link
Author

GitPuffy commented May 3, 2016

Oh no! Things have gone the wrong way now. 😄

With 0.3.2 I can no longer get a short link from within a subcategory (this used to work.) Also, at least in Lavender your new subcategory work/changes do not work from a parent category.

I have 0.3.2 running on my DEV forum. I emailed you the URLs if you want to check them personally.

Thank you.

@rbeer rbeer added the duplicate label May 7, 2016
@rbeer
Copy link
Owner

rbeer commented May 7, 2016

Looks like the same problem as with #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants