improve tab completions #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* nodenv/master: tab complete --help no sense tab-completing the short-form flag handle --complete in case statement use case for verbose flag (and add longform flag) add 'help' as first-class option add nodenv shims to nodenv-each completion
| verbose=1 | ||
| shift | ||
| ;; | ||
| help | --help ) |
There was a problem hiding this comment.
I'm 👎 about supporting rbenv each help (no dashes) usage. All flags should begin with a dash at least.
There was a problem hiding this comment.
agreed. not sure what was in my head at the time
|
| shift | ||
| ;; | ||
| --help ) | ||
| rbenv-help --usage each |
There was a problem hiding this comment.
This should display full help for each, not just --usage
There was a problem hiding this comment.
So the overall plan is --help prints full help, while minimal --usage is only printed when in error? There is inconsistency in this regard, so once decided in general, we can make the rest eventually consistent.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
help,--helpas subcommand for usage