support reading .ruby-version #300
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `rbenv local` command now reads the local ruby version even if the ".rbenv-version" file only exists higher up in the directory chain. Furthermore, this creates a `rbenv-local-version-file` script that has the responsibility of finding local version files and is the only command that has the knowledge of how these files are named.
This was referenced Dec 29, 2012
This is to help with compatibility with versions set from other managers where MRI rubies are prefixed with "ruby-".
|
I've put the logic to strip away "ruby-" in I'm not perfectly happy with this, because it makes |
|
This is a good first start. I have some reservations:
Let's move this over to #302. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work-in-progress to support reading the
.ruby-versionfile if.rbenv-versionis not present. Currently the file is read, but thestring "ruby-" is not stripped from its contents for compatibility with
other Ruby version managers.
First I reorganized code a bit to have only one command that has the
knowledge how local version files are named and looked up:
rbenv-local-version-file.This also improves
rbenv localcommand so it reports the local versioneven if it's set in one of the parent directories, not the current one.
The only next step is to strip "ruby-" from the string read from
.ruby-version. However, I can't think of an elegant way to do that.I'm not sure what is the right level of abstraction to put that logic
in. It certainly doesn't seem like it belongs to
rbenv-version-file-read. @sstephenson, wdyt?