Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a collection of required sh functions isn't going to fly for rbenv. We are making some exceptions for stuff like shell completion where the functionality isn't essential.
I think this is a really nice lightweight convention for defining custom shell helpers. A small
rbenv
command dispatcher is installed atinit
. Regular commands pass though as you'd expect. But special shell commands prefixed withsh-
are called, but its result is evaled in the current shell allowing them to modify environment variables. Whats really cool is this is now a simple plugin framework for anyone to write custom rbenv shell commands.I think we'll start with
rbenv-use
for now. Its basically an alias forexport RBENV_VERSION
.