Relax rustc version to 1.58.1 #2030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0kubun
reviewed
Sep 1, 2022
suggested by @k0kubun Co-authored-by: Takashi Kokubun <takashikkbn@gmail.com>
|
Thanks for your review ❤️ |
eregon
reviewed
Sep 1, 2022
| # Some kind of built-in bash comparison for dotted version strings would be awesome. | ||
| if [[ "${rustc_ver}" == *"rustc 1."[6789]* ]]; then | ||
| # YJIT supports Rust 1.58.1 and later | ||
| if [[ "${rustc_ver}" =~ ^rustc\ 1\.(58\.1|59\.|[6789]\d\.) ]]; then |
There was a problem hiding this comment.
Should it accept 1.58.2 till 1.58.9?
There was a problem hiding this comment.
I don't think there are releases with those numbers: https://github.com/rust-lang/rust/blob/master/RELEASES.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@noahgibbs /cc @k0kubun
YJIT supported rustc-1.58.1+. I suggest relaxing its version on ruby-build because apt package manager of Ubuntu 20.04 and 22.04 provides rustc-1.59.0.