Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Ruby 2.6 as EOL and 2.7 as "unsupported" #2077

Merged
merged 2 commits into from
Nov 2, 2022
Merged

Mark Ruby 2.6 as EOL and 2.7 as "unsupported" #2077

merged 2 commits into from
Nov 2, 2022

Conversation

mislav
Copy link
Member

@mislav mislav commented Nov 1, 2022

Note: I wish we could somehow embed the support/EOL date into the build definition itself so that these warnings could automatically start printing when past the cutoff date instead of us having to ship updates to ruby-build.

Ref. #942

@eregon
Copy link
Member

eregon commented Nov 2, 2022

Indeed. One tricky part is it's not always clear upfront when a release becomes EOL, although end of March seems pretty close: https://en.wikipedia.org/wiki/Ruby_(programming_language)#Table_of_versions

@mislav mislav merged commit 971043c into master Nov 2, 2022
@mislav mislav deleted the ruby-eol branch November 2, 2022 16:59
@jasonkarns
Copy link
Member

jasonkarns commented Nov 2, 2022

@mislav we could maintain a static file in ruby-build that is consulted by the build defs. It would still require updates to ruby-build itself, but wouldn't require retroactively modifying all the build definition files.

relatedly, nodejs has its supported version schedule in a json file. node-build uses this file within our scrapers to automatically add the warning "functions" to the build definitions. it's still retroactively updating build defs the same way as ruby-build here, but at least the changes are automated :D

https://github.com/nodenv/node-build-update-defs/blob/53bc75c641c8cc0cc1d3ae9d1baeda77a2c9b82f/script/lts-lint-definitions

@mislav
Copy link
Member Author

mislav commented Nov 2, 2022

@jasonkarns I'd be up for anything that's semi-automated and less error-prone than the current, by-hand approach 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants