Do not automatically enable YJIT nor attempt to detect rustc #2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest Ruby 3.2 development version now detects `rustc` on the system and automatically assumes `--enable-yjit` on susupported platforms unless `--disable-yjit` was explicitly passed.
eregon
approved these changes
Nov 16, 2022
There was a problem hiding this comment.
I think this makes a lot of sense with how ruby-build in general handles dependencies, and I've already been bitten in the past by dependency checks getting outdated.
There is a mention to install rust on https://github.com/rbenv/ruby-build/wiki, that should be enough and is consistent with where other dependencies are specified.
byroot
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest Ruby 3.2 development version now detects
rustcon the system and automatically assumes--enable-yjiton susupported platforms unless--disable-yjitwas explicitly passed. ruby/ruby#6662I propose that ruby-build does not attempt to duplicate this logic, but that it leaves it completely to Ruby's own build system.
Followup to #1970 /cc @byroot @maximecb