Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove brew update instruction #2151

Merged
merged 2 commits into from
Feb 20, 2023
Merged

Remove brew update instruction #2151

merged 2 commits into from
Feb 20, 2023

Conversation

ohbarye
Copy link
Contributor

@ohbarye ohbarye commented Feb 20, 2023

Same motivation as cli/cli#6087.
I just found that rbenv suggests brew update but it's basically unnecessary.

@ohbarye
Remove brew update instruction
bb2b110 
because `brew update` runs automatically on `brew upgrade` by default since long time ago.
mislav
mislav requested changes Feb 20, 2023
View reviewed changes
Copy link
Member

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! In the past there used to be people setting HOMEBREW_NO_AUTO_UPDATE and forgetting about it, but now that Homebrew 4 is out and API-based installs are the default, I guess being cautious about this is not relevant anymore.

README.md Outdated
@@ -48,7 +48,7 @@ $ ruby-build --definitions # lists all available versions of Ruby
$ ruby-build 2.2.0 ~/local/ruby-2.2.0 # installs Ruby 2.2.0 to ~/local/ruby-2.2.0
```

> **Warning**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whitespace here is meaningful. Please don't commit unrelated changes that your editor makes. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I was so careless. Retrieved those spaces. ad71af3

@mislav mislav merged commit 46878c9 into rbenv:master Feb 20, 2023
@ohbarye ohbarye deleted the remove-brew-update branch February 20, 2023 15:40
@ohbarye
Copy link
Contributor Author

ohbarye commented Feb 20, 2023

Thanks for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mislav mislav mislav requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ohbarye @mislav