Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back on shasum if sha256sum is unavailable #2177

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

jas14
Copy link
Contributor

@jas14 jas14 commented Mar 30, 2023

sha256sum is not by default installed on macOS, but shasum is. They function equivalently, as far as I can tell, so this PR introduces a seamless fallback onto shasum so macOS users can run scripts/update-cruby. 🙂

If desired, I can update the other scripts as well.

@github-advanced-security
Copy link

You have successfully added a new shellcheck configuration differential-shellcheck. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@hsbt hsbt merged commit f2c3a7f into rbenv:master Mar 30, 2023
@hsbt
Copy link
Member

hsbt commented Mar 30, 2023

Thanks!

@jas14 jas14 deleted the osx-update-script branch March 30, 2023 23:13
halostatue added a commit to halostatue/macports-ports that referenced this pull request Apr 28, 2023
This commit contains two updates: 20230424 and 20230428.

```
- 20230424:
  - Fall back on shasum if sha256sum is unavailable by @jas14 in
    rbenv/ruby-build#2177
  - Mark EOL status to Ruby 2.6 and 2.7 by @hsbt in
    rbenv/ruby-build#2180
  - Fix uploading SARIF reports from Differential Shellcheck by @mislav
    in rbenv/ruby-build#2181
  - Fix compilation of Ruby 3.2.x on FreeBSD by @jarmo in
    rbenv/ruby-build#2187
  - Fix truffleruby+graalvm-dev download URLs by @eregon in
    rbenv/ruby-build#2189

- 20230428:
  - Add TruffleRuby 23.0.0-preview1 by @eregon in rbenv/ruby-build#2190
  - Add TruffleRuby+GraalVM 23.0.0-preview1 by @eregon in
    rbenv/ruby-build#2191
```
mojca pushed a commit to macports/macports-ports that referenced this pull request Apr 28, 2023
This commit contains two updates: 20230424 and 20230428.

```
- 20230424:
  - Fall back on shasum if sha256sum is unavailable by @jas14 in
    rbenv/ruby-build#2177
  - Mark EOL status to Ruby 2.6 and 2.7 by @hsbt in
    rbenv/ruby-build#2180
  - Fix uploading SARIF reports from Differential Shellcheck by @mislav
    in rbenv/ruby-build#2181
  - Fix compilation of Ruby 3.2.x on FreeBSD by @jarmo in
    rbenv/ruby-build#2187
  - Fix truffleruby+graalvm-dev download URLs by @eregon in
    rbenv/ruby-build#2189

- 20230428:
  - Add TruffleRuby 23.0.0-preview1 by @eregon in rbenv/ruby-build#2190
  - Add TruffleRuby+GraalVM 23.0.0-preview1 by @eregon in
    rbenv/ruby-build#2191
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants