Patch some popular Ruby versions for Fedora #466
Conversation
|
I against to apply local patches for specify environment. If you can't build these rubies, you should use latest patchlevel or stable version. |
|
Thanks for good intentions, but we have a policy of not shipping patches with ruby-build. We want to maintain a project that installs official Rubies, and lets the user be responsible for appling unofficial patches and risk potentially breaking their installation. However, seeing lately how many Ruby versions are just plain broken on some systems, it makes me think we should reevaluate that policy. @sstephenson: most ruby-build issues opened lately are reports of it not working for some combination of OS + Ruby version which turns out to be a known build bug fixed upstream. What are your thoughts on at least pulling in approved patches from the official Ruby bug tracker? |
|
That's fine by me, this was more of a "works for me and fixes breakage so let's toss it out there" PR, if it helps out someone else, great! It really would be nice though to have upstream patches pulled in at some level, because if we can't build rubies with ruby-build, well... Thanks for the great work! |
Conflicts: share/ruby-build/1.9.3-p194 share/ruby-build/1.9.3-p392 share/ruby-build/1.9.3-p448 share/ruby-build/2.0.0-p247
mislav
changed the title
|
this pull request too old and latest version of ruby has been released. |
reduced diff to not patch the Changeset, and adjusted some line numbers to correct fuzz/offsets.
Fixes #443