Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some ruby-build definitions expect the target (parent) directory to exist #61

Merged
merged 1 commit into from Oct 21, 2011

Conversation

ryanfb
Copy link
Contributor

@ryanfb ryanfb commented Oct 14, 2011

Some ruby-build definitions expect the target (parent) directory to exist, which sometimes isn't there with a fresh rbenv install, so use mkdir as part of the rbenv-install script.

See: https://gist.github.com/b9adc50e729e94fccb28

@sstephenson
Copy link
Contributor

Do you think we ought to do this in ruby-build instead?

@ryanfb
Copy link
Contributor Author

ryanfb commented Oct 20, 2011

Yeah I thought about that, you could instead put it before the cp -R in build_package_copy: https://github.com/sstephenson/ruby-build/blob/master/bin/ruby-build#L171

One issue that might help with is it won't leave behind an empty dir for failed compile installs (though I haven't checked to see if mri/ree/rbx ever have this problem or if it's just JRuby). My logic for putting it in rbenv-install was basically that if you're using ruby-build directly, it's more "obvious" that the parent should exist for the directory you pass it (whereas with rbenv install you're just passing it a version name).

@sstephenson
Copy link
Contributor

Yeah, I think this is an issue with build_package_copy. The prefix doesn't need to exist for autotools installs.

@ryanfb
Copy link
Contributor Author

ryanfb commented Oct 21, 2011

Pull request rewritten as suggested.

sstephenson added a commit that referenced this pull request Oct 21, 2011
Some ruby-build definitions expect the target (parent) directory to exist
@sstephenson sstephenson merged commit a7dc9b1 into rbenv:master Oct 21, 2011
@sstephenson
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants