Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remvoed patch/tiny version from rubinius definitions #883

Closed
wants to merge 1 commit into from

Conversation

hsbt
Copy link
Member

@hsbt hsbt commented Jan 17, 2016

rubinius changed versioning scheme from 2.6 later.

I removed redundant number from rubinius definitions.

@mislav
Copy link
Member

mislav commented Jan 18, 2016

I agree that this follows Rubinius' version policy more closely, but is also a backwards-incompatible change. Users who were previously installing rbx-X.Y.Z definitions will find those to not be working anymore after ruby-build update.

Also, we're not sure if we'll keep supporting Rubinius #862 due to it being a moving target lately and not suitable for hardcoded definitions that we maintain right now.

Also, in my head I've entertained some sort of system in which X.Y and X.Y.0 are recognizes as identical versions within ruby-build and possibly rbenv. That would make these kinds of discrepancies a non-issue.

I'll keep this open until a path forward is more clear.

@hsbt
Copy link
Member Author

hsbt commented Jan 18, 2016

I'll keep this open until a path forward is more clear.

ok, I see.

NOTE: I worried to increase rubinius definitions. Because it released every weeks. We need to have two hundreds definitions one year later. We will support another format for definition maybe.

@jasonkarns
Copy link
Member

It's also worth considering how rbenv-aliases would handle rbx-3.0

As it stands now, rbenv-aliases already creates a symlink from rbx-3.0 to rbx-3.0.0. I'm not sure how rbenv-aliases would handle rbx-3.0 as a true version (probably just wouldn't do anything), but the extra .0 shouldn't be an issue for current rbenv-aliases users.

@hsbt hsbt mentioned this pull request Jan 21, 2016
3 tasks
@deepj
Copy link
Contributor

deepj commented Jan 28, 2016

I'm not sure if the following issue is related to this issue but it seems any rubinius 2.5.x (1) and later is not available publicly on old place -> https://s3.amazonaws.com/releases.rubini.us/ I've meet with that in PR#896 (see log).

  1. except 2.5.8 can be found on new place https://rubinius-releases-rubinius-com.s3.amazonaws.com/rubinius-2.5.8.tar.bz2

@mislav
Copy link
Member

mislav commented Jan 29, 2016

except 2.5.8 can be found on new place

Good catch! Can you send a PR that updates the old URLs?

@deepj
Copy link
Contributor

deepj commented Jan 29, 2016

Unfortunately, I've found Rubinius 2.5.8 only on their new main download site. The rest is available only on Github. See #897

@mislav mislav closed this in 442d4a1 Jan 30, 2016
jasonkarns added a commit to jasonkarns/ruby-build-update-defs that referenced this pull request Feb 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants