Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-DURHO3D_SSE=ON Has no effect #53

Closed
TrevorCash opened this issue Nov 3, 2018 · 2 comments
Closed

-DURHO3D_SSE=ON Has no effect #53

TrevorCash opened this issue Nov 3, 2018 · 2 comments

Comments

@TrevorCash
Copy link
Contributor

(Only Tested On Windows)

I have -DURHO3D_SSE=ON in cmake: But looking at Matrix3x4.h: URHO3D_SSE is not defined:
image

@TrevorCash
Copy link
Contributor Author

TrevorCash commented Nov 3, 2018

This can be fixed by removing the following "Trimming" code from the end of Urho3D.h:

// Disable SSE if compiler does not support it.
#if defined(URHO3D_SSE) && !defined(__SSE2__) && (!defined(_M_IX86_FP) || _M_IX86_FP < 2)
#   undef URHO3D_SSE
#endif

MSVC seems to have an issue with the

!defined(__SSE2__)

part of the condition.
__SSE2__ is defined in SDL but the whole expression is evaluated to true.

@rokups
Copy link
Member

rokups commented Nov 3, 2018

Relevant targets might need sse being enabled through compiler flags

rokups added a commit that referenced this issue Nov 5, 2018
rokups added a commit that referenced this issue Nov 6, 2018
rokups added a commit that referenced this issue Nov 6, 2018
rokups added a commit that referenced this issue Nov 6, 2018
rokups added a commit that referenced this issue Nov 6, 2018
@rokups rokups closed this as completed in 14e5aa3 Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants