Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphics: Ignore borderless parameter unless windows are full-screen. #514

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rokups
Copy link
Member

@rokups rokups commented Jan 28, 2023

I do agree that borderless fullscreen as a default is OK, but it does not make much sense for windowed apps. How about we do something like this?

@rokups rokups requested a review from eugeneko January 28, 2023 09:37
@eugeneko
Copy link
Member

eugeneko commented Jan 28, 2023

Does borderless even work now?
How to create "fullscreen" window without requesting native exclusive fullscreen mode from OS?

Borderless windows are supposed to replace clumsy native fullscreen, and this PR (from the look of it) does the opposite.

@eugeneko
Copy link
Member

We probably just should use enum here.

@rokups
Copy link
Member Author

rokups commented Jan 28, 2023

Good question.. Tbh i have no idea whether this works, because both borderless and actual full screen are identical on my OS, i did not check on windows. However, on windows difference can be spotted when alt+tabbing. Exclusive full-screen takes longer while borderless is immediate. You must know how borderless works in general: just a window without borders, that covers entire screen space.

Borderless windows are supposed to replace clumsy native fullscreen, and this PR (from the look of it) does the opposite.

Huh.. Maybe i misunderstand something, but my intention was precisely for borderless to replace actual full-screen. Problem i am trying to fix here is setting borderless=true for windowed apps causes a non-full-screen window to have no borders, so we can not drag such windows and what not.

@eugeneko
Copy link
Member

Huh.. Maybe i misunderstand something, but my intention was precisely for borderless to replace actual full-screen.

AFAIK our "fullscreen" maps directly onto "native OS fullscreen" and takes precedence.
That's why I should probably just make a enum and clean all this mess xD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants