Obj file support #676
Open
Obj file support #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rokups
reviewed
May 18, 2024
Source/Urho3D/Graphics/Model.MDL.cpp
Outdated
| namespace Urho3D | ||
| { | ||
|
|
||
| bool Model::LoadMDL(Deserializer& source) |
There was a problem hiding this comment.
We do not split a class across multiple cpp files. IMO best we do not start doing it :)
There was a problem hiding this comment.
Why not? If we support several formats for the Model I would prefer the loader code to be isolated. I can't do it as an external loader without major refactoring because of the code for async loading - the loader would need knowledge of and access to internals of the model. I can squash it into one file. Maybe I can extract obj related code that I took from another project to a dedicated cpp...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.obj file, even if it has "Objects" in it doesn't have information about pivots and everything is in world space. I believe it doesn't make sense to split result into multiple nodes. I think it worth to have .obj support right in the engine.
For example here I opened a 1GB photogrammetry file in the Rbfx Editor: