Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

footer update #129

Closed
wants to merge 2 commits into from
Closed

footer update #129

wants to merge 2 commits into from

Conversation

Bashamega
Copy link
Contributor

Fixes #124
image

Copy link
Collaborator

@adityaraute adityaraute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in desktop

image

Text not center aligned in mobile view though

Logo looks good.

@adityaraute
Copy link
Collaborator

Hi @Bashamega ,
Any updates on this one?

@Bashamega
Copy link
Contributor Author

Hi @Bashamega , Any updates on this one?

Sorry I have forgot. I will work on it

@adityaraute
Copy link
Collaborator

Okay, request review whenever it's done

Copy link
Collaborator

@adityaraute adityaraute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect in Mobile view

image

but....

Messed up in Desktop view

image

@adityaraute
Copy link
Collaborator

Do you think putting those changes only under a media query would work?

@mohit-bhandari45
Copy link
Contributor

actually i changed the footer (both mobile and desktop view) firstly you should check that

@Bashamega Bashamega closed this May 1, 2024
@adityaraute
Copy link
Collaborator

Hi @Bashamega
Why was this PR closed?

@Bashamega
Copy link
Contributor Author

Hi @Bashamega Why was this PR closed?

I lost interest. Got busy in other jobs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Footer text wrapping misaligned
3 participants