Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the footer of the website #138

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

mohit-bhandari45
Copy link
Contributor

Fixes #119

Description:-
Fixed the overall ui structure of the footer with proper backgrounds and much more

How Has This Been Tested?
I have tested the code by running it multiple times

Screenshots (if appropriate):
Before:-
image

After:-
image

What types of changes does your code introduce?

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Collaborator

@adityaraute adityaraute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel you are changing the footer too much.
Let's just add circular background to the icons and discard the other changes. Can we do that?

Issues:

Font size too big

image

Mobile view messed up due to the same

image

@mohit-bhandari45
Copy link
Contributor Author

image

Is it good now?

@adityaraute
Copy link
Collaborator

image

Is it good now?

This looks better. Can you also post a screenshot of the mobile view?

@mohit-bhandari45
Copy link
Contributor Author

image

@adityaraute
Copy link
Collaborator

This is how it looks right now

image

The text is center aligned and I prefer it this way. Maybe you could replicate this and only change icons background and move text size back to normal.

@mohit-bhandari45
Copy link
Contributor Author

image
is it good now??

@adityaraute
Copy link
Collaborator

Yes this looks good @mohit-bhandari45

@mohit-bhandari45
Copy link
Contributor Author

Done changes you can check

Copy link
Collaborator

@adityaraute adityaraute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the desktop view is messed up

image

The text on the left is misaligned.

Also, I'm seeing too many unnecessary changes in files regarding formatting and linting. You should try to revert those unnecessary changes, too.

image

A footer change shouldn't take so many line changes.

@mohit-bhandari45
Copy link
Contributor Author

I have done the changes you can check

@adityaraute
Copy link
Collaborator

adityaraute commented May 19, 2024

image is it good now??

  1. The text in mobile view doesn't break into a newline at the required point, as can be seen in your previous messages.

  2. The icon is very close to the border.

image

Let me know if you're able to solve issue 1 without affecting the desktop view.
Issue 2 needs to be solved.

@mohit-bhandari45
Copy link
Contributor Author

I cannot do it

@adityaraute
Copy link
Collaborator

I cannot do it

Okay 1 cannot be solved.
Can 2 be solved? As in, can the icon be moved away from the left border?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: The footer is not well designed
2 participants