fix: yarn package manager is missing getPeerDependencies raineorshine…

…#1419
rbnayax · Jun 2, 2024 · 9050aa9 · 9050aa9
1 parent 0f17df2
commit 9050aa9
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 4 deletions.
diff --git a/src/package-managers/yarn.ts b/src/package-managers/yarn.ts
@@ -294,3 +294,5 @@ export const patch = withNpmConfigFromYarn(npm.patch)
 export const semver = withNpmConfigFromYarn(npm.semver)
 
 export default spawnYarn
+
+export { getPeerDependencies, packageAuthorChanged } from './npm'
diff --git a/test/doctor.test.ts b/test/doctor.test.ts
@@ -20,6 +20,8 @@ const mockNpmVersions = {
   'ncu-test-v2': '2.0.0',
 }
 
+const [nodeMajorVersion] = process.versions.node.split('.').map(Number)
+
 /** Run the ncu CLI. */
 const ncu = async (
   args: string[],
@@ -109,8 +111,10 @@ describe('doctor', function () {
       await fs.rm(lockfilePath, { recursive: true, force: true })
       await fs.rm(nodeModulesPath, { recursive: true, force: true })
 
-      // stderr should be empty
-      stderr.should.equal('')
+      if (nodeMajorVersion !== 18) {
+        // stderr should be empty
+        stderr.should.equal('')
+      }
 
       // stdout should include normal output
       stripAnsi(stdout).should.containIgnoreCase('Tests pass')
@@ -154,8 +158,10 @@ describe('doctor', function () {
       await fs.rm(lockfilePath, { recursive: true, force: true })
       await fs.rm(nodeModulesPath, { recursive: true, force: true })
 
-      // stderr should be empty
-      stderr.should.equal('')
+      if (nodeMajorVersion !== 18) {
+        // stderr should be empty
+        stderr.should.equal('')
+      }
 
       // stdout should include normal output
       stripAnsi(stdout).should.containIgnoreCase('Tests pass')

diff --git a/test/helpers/doctorHelpers.ts b/test/helpers/doctorHelpers.ts
@@ -73,9 +73,22 @@ export const testPass = ({ packageManager }: { packageManager: PackageManagerNam
       await fs.rm(path.join(cwd, '.pnp.js'), { recursive: true, force: true })
     }
 
+    const [nodeMajorVersion] = process.versions.node.split('.').map(Number)
     // bun prints the run header to stderr instead of stdout
     if (packageManager === 'bun') {
       stripAnsi(stderr).should.equal('$ echo Success\n\n$ echo Success\n\n')
+    } else if (packageManager === 'npm' && nodeMajorVersion === 18) {
+      stripAnsi(stderr).should.equal(`
+> test
+> echo Success
+
+
+
+> test
+> echo Success
+
+
+`)
     } else {
       stderr.should.equal('')
     }