Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve deployment to MacOS X #19

Closed
andrsd opened this issue Aug 12, 2021 · 1 comment · Fixed by #21
Closed

Improve deployment to MacOS X #19

andrsd opened this issue Aug 12, 2021 · 1 comment · Fixed by #21

Comments

@andrsd
Copy link
Contributor

andrsd commented Aug 12, 2021

With the current setup this is what MacOS X users would see when they run BeeRef.

image

Note how the version is in the menu bar. This is caused by having the version in the name of the app bundle. This is not a common practice really. Version is typically tracked via Info.plist.

Attached patch makes a small change to change this behavior, so that users would see this:

image

Patch: 00.patch.txt

@rbreu I can open a PR with this change if you like it, or you can go ahead and apply it yourself. Whatever is less hassle for you.

@rbreu
Copy link
Owner

rbreu commented Aug 13, 2021

Oh, okay, I see! I PR would give proper credits to you, but otoh it's a tiny change and easy to apply as a patch. I'll go ahead and to this tonight, unless I spy a PR first.

andrsd added a commit to andrsd/beeref that referenced this issue Aug 13, 2021
- put version in the app bundle
- do not include version in the .app bundle name

Closes rbreu#19
andrsd added a commit to andrsd/beeref that referenced this issue Aug 13, 2021
- put version in the app bundle
- do not include version in the .app bundle name

Closes rbreu#19
@andrsd andrsd mentioned this issue Aug 13, 2021
@rbreu rbreu closed this as completed in #21 Aug 13, 2021
rbreu pushed a commit that referenced this issue Aug 13, 2021
- put version in the app bundle
- do not include version in the .app bundle name

Closes #19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants