-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Empty spaces surrounding the images on the exported scene #83
Comments
This is now fixed in the main branch and will go out with the next release. |
@rbreu I tried testing the development version by building the project(I couldn't start the package using pip) but I'm still having this issue. I did not notice it earlier but this issue does not happen(even in 0.3.1) when I try to load a saved scene & then try to export it without making any changes. The only difference I found between the exported scene is that in version 0.3.1 the exported scene has a bigger file size & the images are of higher & original resolution and in version 0.3.2dev the exported scene is of much smaller file size & the images are of lower resolution. There might've been some issue in building the project on my end which could be the reason I'm seeing this issue even after it's supposed to be fixed, so it would be great if you can test it once more. |
You are right, there were more issues than the one I fixed. I hope commit 310ca14 fixes this for good. Also, there was an issue with setup.py not grabbing all the subdirectories, that should now be fixed as well. |
Describe the bug
There are lots of empty space surrounding the images on the exported scene if we move the images around or make them smaller.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
I'm expecting the exported scene to have only the minimum margin like the first screenshot.
I believe this issue is happening because the width & height of the exported scene is considered at the maximum width & height of the scene/canvas through out it's history rather than the current farthest extent of images (or text).
The default margin is good, so please keep it when fixing this issue.
Screenshots
![example](https://private-user-images.githubusercontent.com/58325574/289370928-9f092876-f254-451a-a571-e1e4a3f4233c.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE1MTgzMDksIm5iZiI6MTcyMTUxODAwOSwicGF0aCI6Ii81ODMyNTU3NC8yODkzNzA5MjgtOWYwOTI4NzYtZjI1NC00NTFhLWE1NzEtZTFlNGEzZjQyMzNjLmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIwVDIzMjY0OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTI2YmI4MTcwNGVkYjUyMjUxOTE5ODQ5NzQ2N2ZlZDYxZWRiMzhlYWIwN2JhZmJmM2M4ZmQ5ZmYxMDFhYjk2MTImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.tIvacF04PDzOEGZiV8RJA80cr4-HxxCPQ_hj7mX4Ljo)
Scene export result right after importing the images:
Scene export result after making some changes & moving images around the canvas.
![example 2](https://private-user-images.githubusercontent.com/58325574/289370935-7d7150dd-edaf-435c-b5c0-9d1e8e520973.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE1MTgzMDksIm5iZiI6MTcyMTUxODAwOSwicGF0aCI6Ii81ODMyNTU3NC8yODkzNzA5MzUtN2Q3MTUwZGQtZWRhZi00MzVjLWI1YzAtOWQxZThlNTIwOTczLmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIwVDIzMjY0OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWE2ZmY1MjdiZWQxMWU0Y2ZmOTI4ZGU3MTUyZmYyYTBjYWExYmRkYjg1ZmU1YzQ4YzJiMjgwOGExMzU2NjMyZjUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.2219pkHyzUCjFAPYIycAJ-cdxJ-JRQGm63jbhXVCCqA)
BeeRef version 0.3.1
Pop OS 22.04
I've been waiting for the last update & I really like this feature, so I hope it can be polished a little more.
The text was updated successfully, but these errors were encountered: