Support Ruby 2.6.x

[DirtyF]

👋

For the record here's the error message you get when using 💎 ruby 2.6.0preview2 (2018-05-31 trunk 63539) [x86_64-darwin17] on macOS:

thread '<unnamed>' panicked at 'Ruby version not supported yet: 2.6.0. Please create a GitHub issue and we'll fix it!', src/core/initialize.rs:251:14

Thanks for this great tool 🔥 😍

[jvns]

Addressing this is actually going to be somewhat complicated because Ruby 2.6 introduces a JIT. I haven't spent any time looking at this yet, but I'd like to!

[joevandyk]

@jvns I don't know a lot about the 2.6 JIT - but I think it's possible to run with it disabled, and I think it's disabled by default?

I'm running into the 2.6.1 not being supported error.

[jvns]

oh, if the JIT is disabled by default then it definitely shouldn't be an issue. I'll take a look!

[ioquatix]

I love rbspy can I help to make it work with 2.6.x?

[seanlinsley]

I haven't used rbspy before but ran into this issue, and would also be happy to help.

[kzys]

Yes. Ruby 2.6's JIT compiler (MJIT) is still experimental and disabled by default.

https://www.ruby-lang.org/en/news/2018/12/25/ruby-2-6-0-released/

In order to enable the JIT compiler, specify --jit on the command line or in the $RUBYOPT environment variable.

We still need to port Ruby's structs (rb_thread_struct?) to rbspy, but it shouldn't be rocket-science hard.

[daniellockyer]

I'm pretty sure I managed to get 2.6.x working with rbspy a couple of months ago, but I can't find the code. I will have another bash at it...

[daniellockyer]

Ok, I think I have 2.5.4, 2.5.5, 2.6.0, 2.6.1, 2.6.2 and 2.6.3 working.

I'm just seeing some weird behavior with the line numbering that also seems to be present in the current version. It's not critical so I'll probably just push so people can get it running

[mikedalpee]

Any idea when you will push this, @neosilky? Would really love to get something going with 2.6.3. Thanks.

[daniellockyer]

@mikedalpee Just pushed! As I said, line numbers are a little broken but you should be able to use it anyway 😀

[mikedalpee]

@neosilky Is there anything special I should do when running this? In particular, does it work with JIT enabled?

[daniellockyer]

@mikedalpee You should just be able to run it out of the box.

I honestly don't know if it'll work with the JIT, I haven't had time to test that. I would suspect some weird stuff goes on though.