-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore C functions in summary rbspy prints out #114
Conversation
Helps address #110 cc @segiddins |
34cf273
to
c1d5dee
Compare
This is great!
|
@jvns this is interesting, some of the methods that show up in the summary don't show up in the flamegraph at all... |
that makes sense -- methods that are too deep in the call stack can get filtered out of the flamegraph (because we only show methods that are more than 2 pixels wide when rendered). so if you have a method which is called in a lot of different places but adds up to maybe 5% of the time overall, it might not show up in the flamegraph but still be fairly important if you really want to dive into why a certain method is being called and it's not obvious from the flamegraph it might be better to use the callgrind output to dig into what's going on ( |
Previously we were including C functions in the summary rbspy prints out. I think it's appropriate to include C functions in a flamegraph, but in the summary they were just causing confusion -- it would report something like "50% of time spend in unknown C function", when in reality those are all probably different C functions.
With this PR, "unknown C function" is only included in the summary if it's the only thing in the stack trace.