Report "trace late" errors in a more understandable way #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvns
force-pushed
the
report-timing-error-better
branch
from
b47d601
to
f5dfae8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you ask rbspy to sample at too high of a rate, it'll start spitting out errors like:
The issue with these errors right now is that it doesn't tell you the magnitude of the problem -- if 1 stack trace is late, it's not a big deal, but if 50% of stack traces are late then that means our results could be pretty inaccurate.
This PR changes the reporting to report the percentage of stack traces that were collected late. We only print out a percentage if it's more than 0.5%.