Incorrect environment detection in WeakMapPolyfill

[wbuchwalter]

In CreateWeakMapPolyfill(), to detect if we are running under node, this code is used:

const isNode = typeof global !== "undefined" &&
  typeof module === "object" &&
  typeof module.exports === "object" &&
  typeof require === "function";

But when using tools which implement CommonJS API in the browser such as Webpack or Browserify, isNode will be incorrectly set to true.

We could replace the check by this one:

 const isNode = Object.prototype.toString.call(global.process) === '[object process]';

Related PR: #7

Thanks!

[vinodsantharam]

+1

[GuillaumeSalles]

+1

[sectore]

Same issue by using jspm.

Behind the scenes SystemJS builder adds an @empty to var nodeCrypto = isNode && require('@empty'); (Reflect.ts#L1351) for using an empty function.

So the check of nodeCrypto (Reflect.ts#L1399) is failed:
Error evaluating XXX/jspm_packages/npm/reflect-metadata@0.1.0/Reflect.js TypeError: 'undefined' is not a function (evaluating 'nodeCrypto.randomBytes(size)')

These issue can be fixed with #7 by @wbuchwalter as well.

-Jens

[wbuchwalter]

Hey @rbuckton , any feedback on this? Thanks!

[tamascsaba]

@rbuckton ????

[rbuckton]

My apologies, I've been out of the office for the past few weeks. I'm also clarifying any CLA requirements for this project before I can accept any pull requests.

[PatrickJS]

👍

[rbuckton]

Closed #8 via #7.

[rolandjitsu]

@rbuckton how soon will this be released?

[rbuckton]

v0.1.1 has been published to npm.