-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect environment detection in WeakMapPolyfill #8
Comments
+1 |
1 similar comment
+1 |
Same issue by using jspm. Behind the scenes SystemJS builder adds an So the check of These issue can be fixed with #7 by @wbuchwalter as well. -Jens |
Hey @rbuckton , any feedback on this? Thanks! |
@rbuckton ???? |
My apologies, I've been out of the office for the past few weeks. I'm also clarifying any CLA requirements for this project before I can accept any pull requests. |
👍 |
@rbuckton how soon will this be released? |
v0.1.1 has been published to npm. |
In CreateWeakMapPolyfill(), to detect if we are running under node, this code is used:
But when using tools which implement CommonJS API in the browser such as Webpack or Browserify, isNode will be incorrectly set to true.
We could replace the check by this one:
Related PR: #7
Thanks!
The text was updated successfully, but these errors were encountered: