Merge branch 'remove_underscore_params'

rca · Jul 19, 2013 · d903402 · d903402
2 parents d1f9e72 + 3ba84f1
commit d903402
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/resourceful/tests/test_filtering.py b/resourceful/tests/test_filtering.py
@@ -23,3 +23,12 @@ def test_attribute_filtering(self):
 
         self.assertEqual(1, len(data['items']))
         self.assertEqual('item1', data['items'][0]['fields']['name'])
+
+    def test_underscore_param_removal(self):
+        w1 = Widget.objects.create(name='item1', quantity=10)
+        w2 = Widget.objects.create(name='item2', quantity=20)
+
+        data = self.get_json('/widget', {'name': 'item1', '_format': 'json'})
+
+        self.assertEqual(1, len(data['items']))
+        self.assertEqual('item1', data['items'][0]['fields']['name'])
diff --git a/resourceful/views.py b/resourceful/views.py
@@ -313,6 +313,9 @@ def _get_request_id_params(self):
         query_params = self.request.REQUEST
 
         for key in query_params:
+            if key.startswith('_'):
+                continue
+
             if key.endswith('_id'):
                 kwargs[key[:-3]] = query_params[key]
             else: