Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

back and next "buttons" missing aria label #59

Closed
AmitTurner opened this issue Nov 27, 2019 · 1 comment
Closed

back and next "buttons" missing aria label #59

AmitTurner opened this issue Nov 27, 2019 · 1 comment

Comments

@AmitTurner
Copy link

According to all page tests and accessibility tests, all Buttons must have discernible text.
meaning, adding
aria-label="back"
and
aria-label="next"
to the arrow buttons will help across all devices and give a better score for search crawlers.
Just my two cents. thanks for the package! amazing work.
@rcaferati
Copy link
Owner

Hey @AmitTurner thanks for raising it. I've added it on v2.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rcaferati @AmitTurner