Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context in documentation around how this package fits in with existing packages #94

Closed
paigem opened this issue Mar 6, 2024 · 4 comments · Fixed by #93
Closed

Comments

@paigem
Copy link
Contributor

paigem commented Mar 6, 2024

Feature suggestion: Add more discussion about how xnemogcm fits into the existing suite of packages currently being used to retrieve and analyze NEMO data.

I suggest adding two sections (which could be quite brief - e.g. a sentence or two each) to the documentation home page:

  1. Put in context with existing NEMO Toolbox
    I saw buried in the description for one of the examples in the documentation that there is a NEMO Toolbox in Fortran. For context for new users, I think it would be helpful to include in the docs how xnemogcm compares/extends/Pythonizes/etc functionality of the existing toolbox (and of any other relevant NEMO tools).

  2. Provide some extra motivation for users to adopt this package by emphasizing easy usage with the Xarray ecosystem
    Is this the first package that allows users to open NEMO data as Xarray Datasets? If so, this should be highlighted as one of the main motivations for this package - that Xarray is widely used in ocean science, and this package will help make NEMO data more analysis-ready for those already familiar with the Xarray ecosystem. I would add this in the README or docs, as this will help new users understand why this is a useful package.

@rcaneill
Copy link
Owner

rcaneill commented Mar 6, 2024

Feature suggestion: Add more discussion about how xnemogcm fits into the existing suite of packages currently being used to retrieve and analyze NEMO data.

I suggest adding two sections (which could be quite brief - e.g. a sentence or two each) to the documentation home page:

  1. Put in context with existing NEMO Toolbox
    I saw buried in the description for one of the examples in the documentation that there is a NEMO Toolbox in Fortran. For context for new users, I think it would be helpful to include in the docs how xnemogcm compares/extends/Pythonizes/etc functionality of the existing toolbox (and of any other relevant NEMO tools).

Yes, there exist tools in Fortran that are used to create domain files, input fields, etc. They are however more used to produce configurations with the necessary input files, than to analyse the outputs. So there is only one overlap, which is recombining the mesh_mask / domaincfg files, when they have been outputted by different processors.

  1. Provide some extra motivation for users to adopt this package by emphasizing easy usage with the Xarray ecosystem
    Is this the first package that allows users to open NEMO data as Xarray Datasets? If so, this should be highlighted as one of the main motivations for this package - that Xarray is widely used in ocean science, and this package will help make NEMO data more analysis-ready for those already familiar with the Xarray ecosystem. I would add this in the README or docs, as this will help new users understand why this is a useful package.

NEMO output files are outputted as netcdf so they can directly be opened by xarray. However, what is missing is all grid information in the shape needed by xgcm (COMODO convention). To solve this problem, another python package existed when I started xnemogcm: xorca. However, it is not developed any more since NEMO 3.6 version (actual NEMO version is 4.2). So xnemogcm is not the first package that allows users to open NEMO data in xarray Datasets and plug to xgcm, but it is the only one still in development and the most flexible one.

I think that this issue will be closed by PR #93

@rcaneill rcaneill linked a pull request Mar 6, 2024 that will close this issue
@paigem
Copy link
Contributor Author

paigem commented Mar 7, 2024

Thanks for this background @rcaneill. I think it would be useful to include this background (of both the Fortran toolkit and xorca) in the README or documentation, as it is helpful for users to have this context (particularly if they have used xorca before and may not know why there is this new package).

For reference, PyOpenSci suggests including this info in the README (it's actually part of my checklist as a reviewer). 😉

@rcaneill rcaneill reopened this Mar 7, 2024
@rcaneill
Copy link
Owner

rcaneill commented Mar 7, 2024

Reopening until #94 (comment) is done

@rcaneill
Copy link
Owner

rcaneill commented Mar 7, 2024

Closed by #103

@rcaneill rcaneill closed this as completed Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants