Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

closes #34 . Enable diagnosing variables on inner grid #57

Merged
merged 3 commits into from
Jul 31, 2023
Merged

closes #34 . Enable diagnosing variables on inner grid #57

merged 3 commits into from
Jul 31, 2023

Conversation

vopikamm
Copy link

@vopikamm vopikamm commented Jul 31, 2023 •
edited
Loading

All of the following horizontal dimension names x/y, x_grid_.../y_grid_... or x_grid_..._inner/y_grid_..._inner are now accepted and equally renamed. closes #34

@vopikamm vopikamm changed the title fixed #34 closes #34 . Enable diagnosing variables on inner grid Jul 31, 2023
rcaneill
rcaneill reviewed Jul 31, 2023
View reviewed changes
xnemogcm/nemo.py Outdated Show resolved Hide resolved
rcaneill
rcaneill reviewed Jul 31, 2023
View reviewed changes
xnemogcm/nemo.py Outdated Show resolved Hide resolved
rcaneill
rcaneill reviewed Jul 31, 2023
View reviewed changes
xnemogcm/nemo.py Outdated Show resolved Hide resolved
Include possibility of dimensions x and x_grid/x_grid_inner and of no…
123f32a 
…t having the same number of dimensions along i and j
rcaneill
rcaneill requested changes Jul 31, 2023
View reviewed changes
Copy link
Owner

@rcaneill rcaneill left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, and it now passes all the tests! Thanks :)

Could you just run black on the code to get the formatting done?

poetry install --with test,dev
poetry run black .

and then commit

@rcaneill
Copy link
Owner

And also add a note in the README, e.g.

## What's new

### not released yet
* Correct bug etc etc

@vopikamm vopikamm requested a review from rcaneill July 31, 2023 15:43
@rcaneill rcaneill merged commit 8bf290a into rcaneill:master Jul 31, 2023
14 checks passed
@rcaneill
Copy link
Owner

Thanks David for fixing this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcaneill rcaneill rcaneill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changed name of dimensions in NEMO4.2 output
2 participants
@vopikamm @rcaneill