Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: behaviors of notification look like vscode #84

Closed
zhang-stephen opened this issue Apr 23, 2022 · 6 comments
Closed

Feature Request: behaviors of notification look like vscode #84

zhang-stephen opened this issue Apr 23, 2022 · 6 comments

Comments

@zhang-stephen
Copy link

as title said, I hope the notification could be configured as popped from bottom right of screen, just like visual studio code.

@rcarriga
Copy link
Owner

The animation style is completely configurable https://github.com/rcarriga/nvim-notify#animation-style so you can define your own style. I've no clue how VS Code notifications appear but I'd be happy to accept a PR to add a similar style to built-in ones 😄

rcarriga added a commit that referenced this issue May 1, 2022
BREAKING CHANGE: Removes `available_row` function.

Allows users to find available rows or columns depending on the
direction.

See #84 and #90
@rcarriga
Copy link
Owner

rcarriga commented May 1, 2022

I've made the existing util function more generic so you can supply a direction to start notifications from. You can copy the stages for the stages you want and change the direction (like in this line https://github.com/rcarriga/nvim-notify/blob/master/lua/notify/stages/fade_in_slide_out.lua#L9) to BOTTOM_UP to get notifications from the bottom.

@zhang-stephen
Copy link
Author

I will have a try.

@rcarriga
Copy link
Owner

rcarriga commented May 5, 2022

Closing this as I believe it is solved. Reopen if not the case

@rcarriga rcarriga closed this as completed May 5, 2022
@akinsho
Copy link
Contributor

akinsho commented Aug 25, 2022

@rcarriga would you be open to a PR to make setting this to open from the bottom require less boilerplate, e.g. allowing the stages to be functions that used internally get passed a default but if imported by the user can be passed a direction, or just adding the bottom position variant (which is less flexible). As the current strategy requires adding approx 60 lines of code, a user likely doesn't need or want to understand for the use case of just changing the positioning of the notification.

@rcarriga
Copy link
Owner

Yes I suppose enough people have wanted this feature in some form or another, allowing for customising the direction would be more beneficial than not, so if someone wants to create a PR I'll happily review 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants