Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable for Where to Split Buffer #97

Closed
trisys3 opened this issue Jan 26, 2022 · 3 comments
Closed

Variable for Where to Split Buffer #97

trisys3 opened this issue Jan 26, 2022 · 3 comments

Comments

@trisys3
Copy link

trisys3 commented Jan 26, 2022

This would essentially replace g:ultest_summary_open. Instead of a long, complicated, but versatile command, this would be a variable for opening to the left, right, top or bottom. The name could be bikeshed later, but for purposes of this issue I'll use g:ultest_summary_position.

Basically:

  • let g:ultest_summary_position = right would do the same thing as the default:
    • let g:ultest_summary_open = "botright vsplit | vertical resize " . g:ultest_summary_width
  • let g:ultest_summary_position = left would do:
    • let g:ultest_summary_open = "topleft vsplit | vertical resize " . g:ultest_summary_width
  • let g:ultest_summary_position = top:
    • let g:ultest_summary_open = "topleft split | resize " . g:ultest_summary_width
  • let g:ultest_summary_position = bottom:
    • let g:ultest_summary_open = "botright split | resize " . g:ultest_summary_width

Not sure how this would deal with legacy code. I suppose g:ultest_summary_position could be empty by default, or g:ultest_summary_width could.

@rcarriga
Copy link
Owner

I don't think I see the need for this. As you've just shown, there is a very simple alternative for each option already, they are not long and complicated. On the other hand, we'd need to handle two conflicting options, as you said, and the new option would be much more limited than the existing one.

@trisys3
Copy link
Author

trisys3 commented Jan 30, 2022

Hmmm... Do you think a documentation update would be useful? I'm relatively familiar with vimL and was able to hack those up, but someone who's never created a vim plugin before would likely have no idea.

@rcarriga
Copy link
Owner

Yes I could definitely see docs being the solution here, happy to add them

rcarriga added a commit that referenced this issue Jan 31, 2022
As requested in #97

Credit to @trisys3 for examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants