Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check all signatures when finalizing #109

Closed
RCasatta opened this issue Jan 19, 2021 · 1 comment
Closed

check all signatures when finalizing #109

RCasatta opened this issue Jan 19, 2021 · 1 comment

Comments

@RCasatta
Copy link
Owner

When doing a 3 of 5, a psbt could receive 5 signatures even if the quorum is, 3. Is it verified that all the signatures are good?
This would expose optional fake signatures even if the tx go through (because 3 signatures are good)
@RCasatta
Copy link
Owner Author

RCasatta commented May 5, 2021

Done in a slightly different way in #120
every time the psbt is printed a signature check is performed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RCasatta