Copy the actual inventory, rather than use the script [rocky] #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 1, 2018 15:44
For all versions of RPC-O, the dynamic inventory script generates a static json file in a fixed path. Rather than trying to run the script (which has different paths depending on the OpenStack series) we can just copy the json file. We implement the logic to check for the presence of a local inventory file before trying to copy it from the MNAIO infra1 source. We also output some debug information to understand which was used when reviewing the console output. JIRA: RE-2030 (cherry picked from commit 1838208)
When doing the pip version check, the stderr output if pip does not exist in the virtualenv is a bit confusing, and not useful for the test. Rather than allowing it to leak, we redirect it to /dev/null. (cherry picked from commit 8bb597d)
johnduarte
approved these changes
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For all versions of RPC-O, the dynamic inventory script generates
a static json file in a fixed path. Rather than trying to run the
script (which has different paths depending on the OpenStack series)
we can just copy the json file.
We implement the logic to check for the presence of a local inventory
file before trying to copy it from the MNAIO infra1 source. We also
output some debug information to understand which was used when
reviewing the console output.
JIRA: RE-2030