Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed solutions tab, horizon-extensions subtree #1643

Merged
merged 1 commit into from Jan 4, 2017
Merged

Removed solutions tab, horizon-extensions subtree #1643

merged 1 commit into from Jan 4, 2017

Conversation

alextricity25
Copy link
Contributor

@alextricity25 alextricity25 commented Dec 22, 2016 •
edited

This commit removes the horizon-extensions subtree,
as well as the bits in the horizon_extenstions playbook
related to deploying the solutions tab.

Connects https://github.com/rcbops/u-suk-dev/issues/868

@alextricity25
Copy link
Contributor Author

recheck_all

@alextricity25 alextricity25 force-pushed the cantu/remove-horizon-extensions branch from 07ce2cd to 748cdb4 Compare January 3, 2017 19:46
Removed solutions tab, horizon_extensions subtree
88859c2 
This commit removes the horizon-extensions subtree,
as well as the bits in the horizon_extenstions playbook
related to deploying the solutions tab.
@alextricity25 alextricity25 force-pushed the cantu/remove-horizon-extensions branch from 748cdb4 to 88859c2 Compare January 4, 2017 13:57
@major major self-requested a review January 4, 2017 14:13
@major major self-assigned this Jan 4, 2017
major
major approved these changes Jan 4, 2017
View reviewed changes
Copy link
Contributor

@major major left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

(Also glad to see this go!)

@evrardjp
Copy link
Contributor

evrardjp commented Jan 4, 2017

LGTM. Removed files, removed references in user_variables, should be ok.
We have to be careful upon upgrades that these variables are still respected, but it should be generally good.

👍

@alextricity25 alextricity25 merged commit b50187d into master Jan 4, 2017
@alextricity25 alextricity25 deleted the cantu/remove-horizon-extensions branch January 4, 2017 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@major major major approved these changes

Assignees

@major major

@evrardjp evrardjp

@alextricity25 alextricity25

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@alextricity25 @evrardjp @major