-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bash completion to openstack clients #193
Conversation
This patch adds bash autocompletion to the following Openstack clients: Cinder Glance Heat Keystone Neutron Nova Autocompletion is only enabled for the rpc_support role and is only available in utility containers. Closes-Bug: #1465723
Adds the templates and playbook to add bash autocompletion to Openstack clients
Could probably just squash these into 1. But 👍 otherwise. Cool! |
Please install it on the infra nodes as well, as we run most commands from these hosts. |
@BjoernT Is there any reason we shouldn't just remove the |
Bash completion will be available in all enviroments where the openstack clients are installed. The autocompletion scripts are placed into a new directory, and are sourced only if their respective client is present in the enviroment. Fixes: #1465723
I'm not fond of the idea of carrying the templates, forcing us to update them whenever a project releases an update. Are these files not already in the source we checkout, or located in the installed wheel? If there's a way that we can pull them from a known and consistent location then we should ideally try to do so. |
@odyssey4me Those are generic bash scripts and not likely going to change from Juno to Kilo etc, in fact not at all. The only upcoming change is once the openstack client takes over and all the other python clients die. I don't see that happening in the near future. @nrb Not really but I prefer to prevent clutter when possible and not installing it everywhere. |
generally in favour of this, but we need an issue to attach it to and to possibly track kilo backports on |
+1 to prometheanfire's comment on an issue. I think this originated from a LaunchPad request. It's also likely this will get backported to Juno. |
Would it be safe to close this request, and resubmit after some more TLC has been given to this? |
I think it's fine, if as was said this will not change much if at all. we just need a tracking issue |
Fixes the issues found through AIO testing Closes: #1465723
@Alfano93 I'd like to look at getting this merged in. To do that the pull request could do with some attention. I'd like you to take a look at the following points:
|
Replaced by #470 |
Adds bash completion to:
Cinder
Glance
Heat
Keystone
Neutron
Nova
All needed packages for bash completion to work have been added to the rpc_support playbooks.
Closes-Bug:#1465723