Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bash completion to openstack clients #193

Closed
wants to merge 4 commits into from
Closed

Add bash completion to openstack clients #193

wants to merge 4 commits into from

Conversation

Alfano93
Copy link
Contributor

Adds bash completion to:

Cinder
Glance
Heat
Keystone
Neutron
Nova

All needed packages for bash completion to work have been added to the rpc_support playbooks.

Closes-Bug:#1465723

This patch adds bash autocompletion to the following Openstack clients:

    Cinder
    Glance
    Heat
    Keystone
    Neutron
    Nova

Autocompletion is only enabled for the rpc_support role and is only available
in utility containers.

Closes-Bug: #1465723
Adds the templates and playbook to add bash autocompletion to Openstack clients
@claco
Copy link
Contributor

claco commented Jun 25, 2015

Could probably just squash these into 1. But 👍 otherwise. Cool!

@BjoernT
Copy link
Contributor

BjoernT commented Jun 29, 2015

Please install it on the infra nodes as well, as we run most commands from these hosts.
Additionally the neutron completion should be installed inside the neutron agents container

@nrb
Copy link
Contributor

nrb commented Jun 29, 2015

@BjoernT Is there any reason we shouldn't just remove the when: line on the include and install these everywhere?

Bash completion will be available in all enviroments where the openstack clients
are installed. The autocompletion scripts are placed into a new directory, and
are sourced only if their respective client is present in the enviroment.

Fixes: #1465723
@odyssey4me
Copy link
Contributor

I'm not fond of the idea of carrying the templates, forcing us to update them whenever a project releases an update. Are these files not already in the source we checkout, or located in the installed wheel? If there's a way that we can pull them from a known and consistent location then we should ideally try to do so.

@BjoernT
Copy link
Contributor

BjoernT commented Jun 29, 2015

@odyssey4me Those are generic bash scripts and not likely going to change from Juno to Kilo etc, in fact not at all. The only upcoming change is once the openstack client takes over and all the other python clients die. I don't see that happening in the near future.

@nrb Not really but I prefer to prevent clutter when possible and not installing it everywhere.

@prometheanfire
Copy link
Contributor

generally in favour of this, but we need an issue to attach it to and to possibly track kilo backports on

@nrb
Copy link
Contributor

nrb commented Jun 29, 2015

+1 to prometheanfire's comment on an issue. I think this originated from a LaunchPad request.

It's also likely this will get backported to Juno.

@Alfano93
Copy link
Contributor Author

Would it be safe to close this request, and resubmit after some more TLC has been given to this?

@prometheanfire
Copy link
Contributor

I think it's fine, if as was said this will not change much if at all.

we just need a tracking issue

Fixes the issues found through AIO testing

Closes: #1465723
@nrb nrb added the prio-1 label Jul 6, 2015
@nrb nrb added prio-2 and removed prio-1 labels Jul 15, 2015
@git-harry
Copy link
Contributor

@Alfano93 I'd like to look at getting this merged in. To do that the pull request could do with some attention. I'd like you to take a look at the following points:

  • create an issue in the repo and reference this pull request against it
  • rebase the commits
  • squash the commits down to one commit
  • remove the reference to the launchpad bug from the commit message
  • all the templates don't look like they have any jinja code in them, if that's the case I think it would be better to use the copy module.

@git-harry
Copy link
Contributor

Replaced by #470

@git-harry git-harry closed this Oct 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
8 participants