change to galaxy roles #578
Conversation
prometheanfire
force-pushed
the
fixing-the-submodules
branch
3 times, most recently
from
24cb0c5
to
260ff34
Compare
|
confirming, this is the bomb |
prometheanfire
force-pushed
the
fixing-the-submodules
branch
8 times, most recently
from
bdedebf
to
ee414fb
Compare
|
👎 If this is a WIP for a bakeoff, maybe we should adjust the PR title accordingly to prevent accidental merge. Additionally, please supply a real commit message, and convert "it puts the stuff in the places" type things to something more befitting of how we wish to present our work as an organization. And finally, maybe we should file an issue for "submodules bad" and reference that in the bakeoffs. |
|
that's fine, this is for a 'bakeoff' as it were |
|
#580 |
|
I'll update the var names when I get in tomorrow |
prometheanfire
force-pushed
the
fixing-the-submodules
branch
8 times, most recently
from
26b2fe3
to
dbcfa77
Compare
prometheanfire
changed the title
| with_dict: "{{repos}}" | ||
| - name: generate rpcd ansible.cfg | ||
| copy: | ||
| dest: /opt/rpc-openstack/rpcd/playbooks/ansible.cfg |
There was a problem hiding this comment.
We supply rpc-openstack/rpcd/playbooks/ansible.cfg -- should that get removed from the repo?
There was a problem hiding this comment.
it isn't removed, but being changed to a dynamically generated file because we are changing to galaxy roles.
There was a problem hiding this comment.
I think the point is that we supply this in the repo when it is cloned:
https://github.com/rcbops/rpc-openstack/blob/master/rpcd/playbooks/ansible.cfg
If you want to generate it dynamically, remove the supplied one
prometheanfire
force-pushed
the
fixing-the-submodules
branch
2 times, most recently
from
16cf888
to
65bca97
Compare
prometheanfire
force-pushed
the
fixing-the-submodules
branch
7 times, most recently
from
cd501d7
to
ac0cbfb
Compare
prometheanfire
force-pushed
the
fixing-the-submodules
branch
6 times, most recently
from
9e29af5
to
8211213
Compare
|
recheck rpc-aio passed this time at least |
prometheanfire
force-pushed
the
fixing-the-submodules
branch
from
8211213
to
660c979
Compare
|
recheck now neither aio pass timeout on verify maas, are we hitting their API limits? |
prometheanfire
force-pushed
the
fixing-the-submodules
branch
from
660c979
to
eef1be2
Compare
prometheanfire
force-pushed
the
fixing-the-submodules
branch
from
eef1be2
to
10331da
Compare
|
|
|
👎 Too much duplication for no benefit. As @d34dh0r53 said, this has been discussed in meetings, on github, in irc and rcbcore, as a team we decided to keep the osa submodule. |
|
neat, reopening makes it get tested again |
|
👎 While I'm not against this idea at some point, I don't think we need to do this right now. |
|
ok, no code for you |
youre welcome