Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sourceLaneId equal targetLaneId? #25

Closed
Macragge opened this issue Oct 4, 2017 · 3 comments
Closed

sourceLaneId equal targetLaneId? #25

Macragge opened this issue Oct 4, 2017 · 3 comments
Assignees
@rcdexta
Labels
bug

Comments

@Macragge
Copy link

Macragge commented Oct 4, 2017

Hi,
when implementing drag & drop behaviour it seems like the parameters sourceLaneId and targetLaneId which are given within the handleDragEnd-method are the same. In your Demo it is working correctly but when i use the code which is in your story.js it shows the beviour i just described above.
@rcdexta
Copy link
Owner

rcdexta commented Oct 4, 2017

Ok let me check that. Does this happen when you move the card from one lane to another or juggling within the same lane?

@Macragge
Copy link
Author

Macragge commented Oct 5, 2017

When i move it between lanes so in your example when i move from planned to wip source and target are always planned

@rcdexta rcdexta added the bug label Oct 12, 2017
@rcdexta rcdexta self-assigned this Oct 12, 2017
rcdexta added a commit that referenced this issue Oct 12, 2017
@rcdexta
fix: Call handleDragEnd only when the card has been moved within a la…
e501f14 
…ne to a different position or a

#25
@rcdexta
Copy link
Owner

rcdexta commented Oct 12, 2017

This issue should be fixed now. Refer again to this example for implementing drag-n-drop: https://github.com/rcdexta/react-trello/blob/master/stories/DragDrop.story.js

Make sure the lane id is unique for each lane since it is passed along to the handleDragEnd method. Use v1.21.4

@rcdexta rcdexta closed this as completed Oct 12, 2017
reactexp925 added a commit to reactexp925/react-trello that referenced this issue Dec 5, 2019
@reactexp925
fix: Call handleDragEnd only when the card has been moved within a la…
762c082 
…ne to a different position or a

rcdexta/react-trello#25
pikachunerdy added a commit to pikachunerdy/react-trello that referenced this issue Oct 7, 2022
@pikachunerdy
fix: Call handleDragEnd only when the card has been moved within a la…
6b73358 
…ne to a different position or a

rcdexta/react-trello#25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rcdexta rcdexta

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rcdexta @Macragge