New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integer parsing failure #49

Merged

rcdilorenzo merged 1 commit into rcdilorenzo:master from unknown repository

Nov 6, 2017

ghost commented Nov 6, 2017

Filtrex.Conditions.Number always causes a parsing failure on any integer value. It immediately fails when(both condition must be satisfied):

options are configured with allow_decimal: false
value (to be parsed) is integer %{"age_equals" => 1}


          Fix integer parsing failure

91def9a

ghost mentioned this pull request

Integer validation always fails #50

Closed

Owner

rcdilorenzo commented Nov 6, 2017

@v3dr4n Thanks for the fix. Looks good!

rcdilorenzo merged commit b59918c into rcdilorenzo:master

goravbhootra mentioned this pull request

filtering on number field #51

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment