Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2021 position of apptainersingularity pages in tocs is unexpected #2053

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Carldkennedy
Copy link
Contributor

Renamed singularity.rst to apptainer.rst
Added stub for singularity

@Carldkennedy Carldkennedy self-assigned this Mar 28, 2024
@Carldkennedy
Copy link
Contributor Author

However, Singularity/Apptainer still shows along with Apptainer/Singularity in TOC even though added :hidden: yes to stub
Should we keep this double entry?

@willfurnass
Copy link
Contributor

I don't think we need 'Singularity' entries in TOCs provided that people can still find mention of Singularity on Apptainer pages via the site's search functionality.

2 similar comments
@willfurnass
Copy link
Contributor

I don't think we need 'Singularity' entries in TOCs provided that people can still find mention of Singularity on Apptainer pages via the site's search functionality.

@willfurnass
Copy link
Contributor

I don't think we need 'Singularity' entries in TOCs provided that people can still find mention of Singularity on Apptainer pages via the site's search functionality.

@Carldkennedy Carldkennedy marked this pull request as draft March 28, 2024 12:04
Copy link
Contributor

@nikishe nikishe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/home/runner/work/sheffield_hpc/sheffield_hpc/stanage/software/apps/index.rst:6:toctree contains reference to document 'stanage/software/apps/singularity'

@Carldkennedy
Copy link
Contributor Author

Singularity was still being picked up by toc even though orphan directive added to .rst

@Carldkennedy Carldkennedy marked this pull request as ready for review March 28, 2024 14:41
@jkwmoore
Copy link
Contributor

I think manually specifying the sub pages like this is a bad idea even if it does resolve two entries for Apptainer.

@Carldkennedy
Copy link
Contributor Author

Conflicting opinions here. Does anyone knows of a fix that would hide singularity from the toc (other than :orphan: directive)

@jkwmoore
Copy link
Contributor

jkwmoore commented Apr 5, 2024

I have added a commit which should achieve what we want. Let me know what people think. If we are happy with this we should also add a small amount of info to the README.

Some additional context on why bodge (no better native methods that Sphinx support yet/still):

@Carldkennedy
Copy link
Contributor Author

LGTM @jkwmoore, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Position of 'Apptainer/Singularity' pages in TOCs is unexpected
4 participants