Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#34 - Liquid Democracy #28

Merged

Conversation

raviclalwani
Copy link
Collaborator

Hackthon 2020

@dckc
Copy link
Contributor

dckc commented Nov 9, 2020

This looks like very nice work!

Here's hoping I find time to test it just a bit so I can merge it.

@jimscarver have you tested it, by chance?

@jimscarver
Copy link
Contributor

I witness a test. It works!

@jimscarver jimscarver requested a review from dckc November 9, 2020 13:31
@jimscarver
Copy link
Contributor

retest results looks good BUT
image
The template fields for sendMail stick for every function!!!
image

@jimscarver jimscarver marked this pull request as draft November 9, 2020 13:58
@dckc
Copy link
Contributor

dckc commented Nov 9, 2020

@raviclalwani now that @jimscarver tested this I'd like to go ahead and merge it. The github button is disabled because this is still a draft PR. Is there any particular reason that it's not ready?

I can merge it using command-line tools.

@dckc
Copy link
Contributor

dckc commented Nov 9, 2020

@jimscarver writes:

The template fields for sendMail stick for every function!!!

escalated to its own issue: #29

@raviclalwani raviclalwani marked this pull request as ready for review November 9, 2020 16:04
@raviclalwani
Copy link
Collaborator Author

@raviclalwani now that @jimscarver tested this I'd like to go ahead and merge it. The github button is disabled because this is still a draft PR. Is there any particular reason that it's not ready?

I can merge it using command-line tools.

Hi Dan,

I have update the PR and its no longer a draft. There are no code changes.

@jimscarver jimscarver marked this pull request as draft November 9, 2020 16:45
@jimscarver jimscarver self-assigned this Nov 9, 2020
@jimscarver jimscarver marked this pull request as ready for review November 9, 2020 16:55
@dckc dckc merged commit 97eebd0 into rchain-community:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants