deploy fails without error message

[jimscarver]

What did you expect to see?

output to deployId - counts, {"red": 2, ...

What did you see instead?

Deploy error when executing Rholang code.

Steps to reproduce the bug

create an issue, adding a voter, tallying a vote having at least one voter.
See https://docs.google.com/document/d/1V5k9tDjztEVDYiXJG1-Hpb0rNtVcV22GrsdXb0pDUx8/edit#

What version of RNode are you using?

0.10.0/1/2

What is your environment?

https://github.com/rchain-community/liquid-democracy/blob/reorganize-actions/src/actions/tallyVotes.rho
shows correct execution in the log but fails returning a value at deployId but the test when defining tally works fine. https://github.com/rchain-community/liquid-democracy/blob/reorganize-actions/Issue.rho
http://rhobot.net:40403/api/block/d4407236ee4408c4584404c22e0e6bd4d7c6f20dd90a910b5d6d30096703d7f8
see rchain-community/rchain-api#86

[dckc]

@jimscarver did you say a couple other people reproduced this bug? Who were they?

[jimscarver]

@w2vy and @Bill-Keuntje confirmed the bug

[jimscarver]

Any vote causes the choice and tally to fail independently but in this case adding immediate tally/choice does not cause the error. https://gist.github.com/jimscarver/8b5a7733592855a117ded183d8d55e0b

https://github.com/rchain-community/liquid-democracy/blob/reorganize-actions/Issue.rho also runs without an error.

[Bill-Kunj]

The message appeared because of the code
log!((name ++ "delegates to" ++ delegate))
Where 'name' is a URI. But, the '++' operator is not defined for URI. The interpreter silently (no log message) indicates an error which gets reported to the API, which in turn produces "Deploy error when executing Rholang code".

[dckc]

Thanks for the update, @Bill-Keuntje

[jimscarver]

using version 0.10.2 (4220ea8) there is no error message if you misspell a function name. The code does nothing and if you do not listen on deployId you get no indication at all that there was an error.

A whole section of code was silently not being executed because I misspelled contain. The deploy and propose succeeds without any indication of an error.

[w2vy]

I am getting closer to fixing this right. The pyrchain project looks very promising

…

On May 1, 2021 2:25:48 PM EDT, Jim Whitescarver ***@***.***> wrote: using version 0.10.2 (4220ea8) there is no error message if you misspell a function name. The code does nothing and if you do not listen on deployId you get no indication at all that there was an error.  A whole section of code was silently not being executed because I misspelled contain. The deploy and propose succeeds without any indication of an error. -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #3375 (comment)

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

[tgrospic]

Closing because it seems this is not an issue with RNode. Please reopen if you think otherwise.

[dckc]

Collapsing all method call errors to a single "Deploy error" diagnostic sure seems like an issue in rnode to me. It makes the dev UX pretty horrible.

log!((name ++ "delegates to" ++ delegate))
Where 'name' is a URI. But, the '++' operator is not defined for URI. The interpreter silently (no log message) indicates an error which gets reported to the API, which in turn produces "Deploy error when executing Rholang code".