Message propagation improvement #2902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgrospic
requested changes
Mar 7, 2020
casper/src/main/scala/coop/rchain/casper/util/comm/CommUtil.scala
Outdated
Show resolved
Hide resolved
casper/src/main/scala/coop/rchain/casper/util/comm/CommUtil.scala
Outdated
Show resolved
Hide resolved
comm/src/main/scala/coop/rchain/comm/transport/StreamHandler.scala
Outdated
Show resolved
Hide resolved
comm/src/main/scala/coop/rchain/comm/transport/GrpcTransportServer.scala
Show resolved
Hide resolved
zsluedem
reviewed
Mar 8, 2020
tgrospic
reviewed
Mar 8, 2020
tgrospic
reviewed
Mar 8, 2020
casper/src/test/scala/coop/rchain/casper/engine/RunningMaintainRequestedBlocksSpec.scala
Outdated
Show resolved
Hide resolved
nzpr
force-pushed
the
block-propagation
branch
3 times, most recently
from
899a166
to
2c59e8c
Compare
tgrospic
reviewed
Mar 9, 2020
comm/src/main/scala/coop/rchain/comm/transport/GrpcTransportClient.scala
Outdated
Show resolved
Hide resolved
tgrospic
reviewed
Mar 9, 2020
comm/src/main/scala/coop/rchain/comm/transport/GrpcTransportClient.scala
Outdated
Show resolved
Hide resolved
nzpr
force-pushed
the
block-propagation
branch
2 times, most recently
from
78fd6b0
to
871d0ce
Compare
|
I'm leaving schedulers tuning for future PR. We should investigate whats the best way. |
tgrospic
approved these changes
Mar 10, 2020
zsluedem
approved these changes
Mar 10, 2020
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Result of WIP in of #2897 and #2891
This PR enable discarding of duplicate messages to lower down load on Casper and system in general.
Moreover, bloat was found in consumption of streamed GRPC messages (blocks) which lead to over a hundred of messages waiting for processing as per
tmp/comm. It is fixed as well.As a result, we can see nodes advancing nicely when creating blocks simultaneously (synchrony constraint 0.67).
Notes
Optional. Add any notes on caveats, approaches you tried that didn't work, or anything else.
Please make sure that this PR:
Bors cheat-sheet:
bors r+runs integration tests and merges the PR (if it's approved),bors tryruns integration tests for the PR,bors delegate+enables non-maintainer PR authors to run the above.