Fix generation of bonds and wallets file #3338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nzpr Please add to the description of PR a short summary of what changes are done in the code. This should be the complement to linked issue. If there is no linked issue, PR should also contain the info about the problem it solves. |
nzpr
force-pushed
the
fix-wallets
branch
2 times, most recently
from
2c4c64d
to
f305346
Compare
tgrospic
approved these changes
Mar 2, 2021
casper/src/main/scala/coop/rchain/casper/util/BondsParser.scala
Outdated
Show resolved
Hide resolved
casper/src/main/scala/coop/rchain/casper/util/VaultParser.scala
Outdated
Show resolved
Hide resolved
casper/src/main/scala/coop/rchain/casper/util/VaultParser.scala
Outdated
Show resolved
Hide resolved
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Mar 3, 2021
3338: Fix generation of bonds and wallets file r=nzpr a=nzpr Some old PR refactoring config e2bbe2f broken autogeneration of bonds file and made node require wallets file without any fallback. This PR fixes user experience. **The rule for bonds:** if no bonds file at path specified (or default `genesis_path/bonds.txt` if nothing specified) does not exist - node will generate one for user. If bonds file exists but is empty node will report error and exit. **The rule for wallets:** if no wallets file - node reports that genesis won't have any genesis vault. No exception possibly thrown. Empty wallets file is allowed. closes #3008 Co-authored-by: nutzipper <1746367+nzpr@users.noreply.github.com>
|
Build failed: |
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Mar 3, 2021
3338: Fix generation of bonds and wallets file r=nzpr a=nzpr Some old PR refactoring config e2bbe2f broken autogeneration of bonds file and made node require wallets file without any fallback. This PR fixes user experience. **The rule for bonds:** if no bonds file at path specified (or default `genesis_path/bonds.txt` if nothing specified) does not exist - node will generate one for user. If bonds file exists but is empty node will report error and exit. **The rule for wallets:** if no wallets file - node reports that genesis won't have any genesis vault. No exception possibly thrown. Empty wallets file is allowed. closes #3008 Co-authored-by: nutzipper <1746367+nzpr@users.noreply.github.com>
|
Build failed: |
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some old PR refactoring config e2bbe2f broken autogeneration of bonds file and made node require wallets file without any fallback.
This PR fixes user experience.
The rule for bonds: if no bonds file at path specified (or default
genesis_path/bonds.txtif nothing specified) does not exist - node will generate one for user. If bonds file exists but is empty node will report error and exit.The rule for wallets: if no wallets file - node reports that genesis won't have any genesis vault. No exception possibly thrown. Empty wallets file is allowed.
closes #3008