Make reporting replay system deploys #3397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsluedem
force-pushed
the
ISSUE-2981-reporting-replay-sysdem-deploys-2
branch
from
1eb3df7
to
e43bfdf
Compare
|
bors try |
tryBuild succeeded: |
zsluedem
force-pushed
the
ISSUE-2981-reporting-replay-sysdem-deploys-2
branch
from
e43bfdf
to
1f70dd1
Compare
|
bors try |
tryBuild failed: |
|
bors try |
tryBuild failed: |
zsluedem
force-pushed
the
ISSUE-2981-reporting-replay-sysdem-deploys-2
branch
2 times, most recently
from
149e581
to
331b887
Compare
tgrospic
reviewed
May 20, 2021
casper/src/main/scala/coop/rchain/casper/util/rholang/CasperRhoRuntimeSyntax.scala
Outdated
Show resolved
Hide resolved
casper/src/test/scala/coop/rchain/casper/batch1/MultiParentCasperReportingSpec.scala
Outdated
Show resolved
Hide resolved
zsluedem
force-pushed
the
ISSUE-2981-reporting-replay-sysdem-deploys-2
branch
from
331b887
to
6dd5687
Compare
zsluedem
commented
Jun 1, 2021
casper/src/main/scala/coop/rchain/casper/api/BlockReportAPI.scala
Outdated
Show resolved
Hide resolved
tgrospic
changed the title
|
As we discussed on standup. Let's keep reporting API on external and internal the same with force parameter included. Reporting is protected with config flag. |
zsluedem
commented
Jun 8, 2021
| } yield SystemDeployReportResult(term.systemDeploy, r) | ||
| } | ||
|
|
||
| checkPoint <- runtime.createCheckpoint |
There was a problem hiding this comment.
createCheckpoint here would store the items again which is not neccessary at all. All we need here is the proof while the history current implementation is difficult to change the storing part we would leave that into another pr.
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Make reporting replay system deploys and adds parameter
forceReplayto trace API method to execute reporting replay even when exists in cache.Related #2981
Reporting API is now also available together with other methods on web and admin
/api/traceroute. Oldreporting/traceis not changed.Please make sure that this PR:
Bors cheat-sheet:
bors r+runs integration tests and merges the PR (if it's approved),bors tryruns integration tests for the PR,bors delegate+enables non-maintainer PR authors to run the above.