New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infos before next pull-request. #1
Comments
In previous post please read:
In image.pas was changed all The changes, ready to a pull-request, are here: Fre;D |
Hello Fred! Thank you for your work and for the informations. I agree with using ObjFPC mode everywhere, and with the other modifications. I am very glad that you could compile and run Eschecs under Linux. I hope we will be able to make a release soon. I will look at your modifications today. Best regards. Roland |
The big question is: does the Linux version of Eschecs work in "human versus engine" mode? I am wondering what we are going to do with the engines.json file. Maybe we could create two files, something like windows-engines.json and linux-engines.json? And the application would select automatically the good file. |
To test the communication with the engine, you could use Moustique (1) and, for example, Fruit 2.1, which is available for Linux here: (1) I suggest to compile Moustique with -dDEBUG, so it will produces a log file. |
Hello Roland.
Huh, it must work (if I am able to enable moustique). I have done a pull request. Fre;D |
Hello. Tested for Windows too.
Maybe you could keep only one Json file and add some items. Something like this:
and in engines.pas do something like this:
Fre;D |
Hello Fred! I am so glad that the whole application works! Thank you very much for that great contribution. By the way, you could compile with -dOPT_HIGHLIGHT to enable the square highlighting (not sure that it is the right english word, but you will understand what it is if you try it). Your idea about the JSON file is interesting. Have a good night! Best regards. Roland |
Happy that you are happy. Fre;D |
On Linux, programs have kind of predefined paths. So we could put those in the Json file or autodetect them in the code. |
@circular17 |
Hello Roland.
Before to propose a pull-request, here the modifs done.
There was still problems with the Pascal mode.
Is it a reason why you need Delphi mode as default?
Because using other code, like BgrabBitmap or fpGui that use {$mode objfpc}, may create conflicts.
{$mode delphi} is more tolerant about assignation of pointer of pointer ( ^^ ) for example.
If you agree, in next pull-request I will use {$mode objfpc} in all your code.
Other thing, with BGRAfpGUIBitmap.pas, I get a error message compiling on Linux:
bgrafpguibitmap.pas(51,14) Error: (3058) There is no method in an ancestor class to be overridden: "LoadFromDevice(LongInt;TRect);"
bgrafpguibitmap.pas(57,1) Fatal: (10026) There were 2 errors compiling module, stopping
Fatal: (1018) Compilation aborted
So I disabled those 2 methods in BGRAfpGUIBitmap.pas for Linux (maybe a bug report would be welcome).
In image.pas was changed all "" with "directoryseparator" to be Unix compatible.
Last thing, Linux is case-sensitive so, I did change {$R eschecs.res}.
Now all compile ok.
[EDIT] and runs OK.
https://sites.google.com/site/fredvsbinaries/eschecs_linux.png
Fre;D
The text was updated successfully, but these errors were encountered: